Refactor actions cache to be build on main #20144
Conversation
mockersf
force-pushed
the
refactor-actions-cache
branch
from
3389f8b to
f893744
Compare
alice-i-cecile
added
A-Build-System
.github/workflows/ci.yml
Outdated
| # key won't match, will rely on restore-keys | ||
| key: ${{ runner.os }}-stable--${{ hashFiles('**/Cargo.toml') }}- | ||
| restore-keys: | | ||
| ${{ runner.os }}-stable--${{ hashFiles('**/Cargo.toml') }}- | ||
| ${{ runner.os }}-stable-- |
There was a problem hiding this comment.
Just a nit: I would document that these have to follow the keys in update-caches.yml
| path: | | ||
| ~/.cargo/bin/ |
There was a problem hiding this comment.
In the future, we should look into caching ~/.cargo/.crates.toml and ~/.cargo/.crates2.json, as they track which executables were installed with cargo install. Not something we need to do now, though, since we don't install anything with cargo install :)
BD103
added
S-Waiting-on-Author
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
mockersf
added
S-Ready-For-Final-Review
| @@ -24,6 +25,20 @@ jobs: | |||
| - name: Disable audio | |||
| # Disable audio through a patch. on github m1 runners, audio timeouts after 15 minutes | |||
| run: git apply --ignore-whitespace tools/example-showcase/disable-audio.patch | |||
| - uses: actions/cache/restore@v4 | |||
There was a problem hiding this comment.
We have a ton of copy-pasted cache code so every adjustment or fix has to touch a lot of places and you're bound to miss one at some point.
I strongly suggest we create a composite action for that, which could be done directly in this repo, in .github/actions.
But if you want, it can be tackled in a separate PR :)
Objective
Solution